mechanic: clump stat gains on prime stats only

pqcli/mechanic.py

@@ -398,12 +398,12 @@ class Player(SignalMixin):
             chosen_stat = random.choice(list(StatType))
         else:
             # favor the best stat so it will tend to clump
-            t = sum(value**2 for _stat, value in self.stats)
+            t = sum(self.stats[stat] ** 2 for stat in PRIME_STATS)
             t = random.below(t)
             chosen_stat = None
-            for stat, value in self.stats:
+            for stat in PRIME_STATS:
                 chosen_stat = stat
-                t -= value**2
+                t -= self.stats[stat] ** 2
                 if t < 0:
                     break
 

tests/test_mechanic.py

@@ -1,7 +1,9 @@
 import datetime
 
+import pytest
+
 from pqcli import random
-from pqcli.config import StatType
+from pqcli.config import PRIME_STATS, StatType
 from pqcli.game_data import load_game_data
 from pqcli.mechanic import Player, Simulation, Stats, level_up_time
 
@@ -36,3 +38,18 @@ def test_quest_length_matches_upstream() -> None:
         lengths.add(simulation.player.quest_book.quest_bar.max_)
     assert min(lengths) == 50
     assert max(lengths) == 149
+
+
+def test_weighted_stat_gain_skips_hp_and_mp(
+    monkeypatch: pytest.MonkeyPatch,
+) -> None:
+    # the "favor the best stat" branch only covers prime stats, pq-web 48c42e6
+    monkeypatch.setattr(random, "odds", lambda chance, out_of: False)
+    random.seed("stats")
+    player = make_simulation().player
+    player.stats.increment(StatType.hp_max, 1000)
+    for _ in range(500):
+        player.win_stat()
+    assert player.stats[StatType.hp_max] == 1010
+    assert player.stats[StatType.mp_max] == 10
+    assert sum(player.stats[stat] for stat in PRIME_STATS) == 60 + 500